Develop #3
Merged
Develop #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to QRectF conversion as is done elsewhere in the code already
…adConfig instead of filePath
previous code only allowed overwrite of existing files, no new files could be created
…teractively creating connections
|
fair enough about running inside an environment that has already supplied a QApplication and an event loop... but shouldn't the demo simply run from the command line by doing "python nodz_demo.py" |
already has a QApp+event loop
|
OK... so I've addressed the concern by doing a try/except on the creation of the QApp and only do an exec if an app was created |
|
Just to add my voice to this - I hit these exact same issues when trying to run from the cli. These changes resolved the issue. Maya isn't listed as a prerequisite - so if it's expected that Maya is in the mix, then it should really be added to the docs, but making nodz available to standalone devs would have a great deal more value in my mind. |
LeGoffLoic
approved these changes
Jul 7, 2017
glm-ypinczon
added a commit
to glm-ypinczon/Nodz
that referenced
this pull request
Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had a few minor problems trying out the demo code... here are my fixes for those issues