Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post 1.13.2 textures (#29) #191

Merged
merged 4 commits into from
Oct 16, 2021

Conversation

Vivi-17
Copy link
Contributor

@Vivi-17 Vivi-17 commented Sep 25, 2021

No description provided.

@Koboo
Copy link

Koboo commented Sep 26, 2021

Tried this PR on 1.16 paperspigot.

Got following issues in console:

[main.rs:470][WARN] Failed to obtain mutable reference to resource manager!
[model/mod.rs:225][ERROR] Error missing block state for minecraft:cut_red_sandstone_slab
[model/mod.rs:196][ERROR] Error loading model minecraft:cut_red_sandstone_slab
[model/mod.rs:225][ERROR] Error missing block state for minecraft:standing_banner
[model/mod.rs:196][ERROR] Error loading model minecraft:standing_banner
[model/mod.rs:225][ERROR] Error missing block state for minecraft:oak_wood
[model/mod.rs:196][ERROR] Error loading model minecraft:oak_wood
[model/mod.rs:225][ERROR] Error missing block state for minecraft:bed
[model/mod.rs:196][ERROR] Error loading model minecraft:bed
[model/mod.rs:225][ERROR] Error missing block state for minecraft:smooth_quartz
[model/mod.rs:196][ERROR] Error loading model minecraft:smooth_quartz
[model/mod.rs:225][ERROR] Error missing block state for minecraft:smooth_stone
[model/mod.rs:196][ERROR] Error loading model minecraft:smooth_stone
[model/mod.rs:225][ERROR] Error missing block state for minecraft:dead_brain_wall_fan
[model/mod.rs:196][ERROR] Error loading model minecraft:dead_brain_wall_fan
[model/mod.rs:225][ERROR] Error missing block state for minecraft:dead_bubble_wall_fan
[model/mod.rs:196][ERROR] Error loading model minecraft:dead_bubble_wall_fan
[model/mod.rs:225][ERROR] Error missing block state for minecraft:prismarine_stairs
[model/mod.rs:196][ERROR] Error loading model minecraft:prismarine_stairs
[model/mod.rs:225][ERROR] Error missing block state for minecraft:light_gray_wool
[model/mod.rs:196][ERROR] Error loading model minecraft:light_gray_wool

@Vivi-17
Copy link
Contributor Author

Vivi-17 commented Sep 26, 2021

Tried this PR on 1.16 paperspigot.

Got following issues in console:
[...]

@Koboo I also got these issues during testing, but the mappings (especially the IDs of the materials) for the different versions should be correct. It's kind of weird..

@terrarier2111
Copy link
Member

The models just can't be loaded, because of differing names from materials/textures

@terrarier2111
Copy link
Member

terrarier2111 commented Sep 26, 2021

But that's a different issue

@Koboo
Copy link

Koboo commented Sep 26, 2021

Sry, I didn't know that. But very good work. My appreciation goes to the whole team behind Leafish! Keep up! 👍

@terrarier2111
Copy link
Member

The ids here are wrong, please recheck them

@terrarier2111 terrarier2111 merged commit c868e53 into Lea-fish:main Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants