Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid mixed-content errors if loaded over HTTPS #196

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

Avoid mixed-content errors if loaded over HTTPS #196

wants to merge 3 commits into from

Conversation

cben
Copy link

@cben cben commented Feb 25, 2015

@cben
Avoid mixed-content errors if loaded over HTTPS
f329c81 
GH Pages got (unofficial) HTTPS support since April 2014:
https://konklone.com/post/github-pages-now-sorta-supports-https-so-use-it
and at least HTTPS Everywhere users will load https://leaverou.github.io/animatable/ and scratch their heads why nothing animates.

Left the main JS reference protocol-relative so http doesn't entirely break for non-SNI browsers (IE on XP, stock browser on Android 2.x) or in case Github's https support breaks.
AFAIK google analytics URL works but might cause security popup on IE6.
@cben
Use github.io because https://leaverou.github.com 301s to http://leav…
8fd7a5b 
…erou.github.io

which resulted in mixed-content error despite the protocol-relative url.
@treyhunner
Copy link

👍 I had to use that version because my browser was redirecting to the HTTPS URL

@LeaVerou
Copy link
Owner

The problem with // is that it doesn’t work locally anymore (over file://) :/

@cben
Copy link
Author

cben commented Jul 19, 2015

Fixed local usage at the expense of non-SNI browsers.
IE6 on XP and Android 2.x will probably break, even when loading via http://leaverou.github.io/animatable/.
If you care about those, I could make all work with document.location.protocol sniffing.

@cben
Copy link
Author

cben commented Jul 19, 2015

IE6 doesn't render anything useful anyway.
Don't have access to [simulate] an old enough android to check. SSL Labs claims android 2.x handshake to github pages does succeed (without SNI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cben @treyhunner @LeaVerou