Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for open() will not open list before any input event #16740

Closed
wants to merge 1 commit into from
Closed

Fix for open() will not open list before any input event #16740

wants to merge 1 commit into from

Conversation

steelywing
Copy link

Reproduce:

  • Don't fire any input event (don't key in anything)
  • [Optional] Set input via JS $('input').val('test')
  • Call awesomplete.open()

Issue:

  • List will not open

@vlazar
Copy link
Collaborator

vlazar commented May 30, 2015

Nice catch!

@LeaVerou Any chance you'll have some free time in the near future to look at #16734 ? Fixing bugs would be safer if we have quick and easy way to run tests and, of course, more tests (which I already have and waiting for you response on #16734).

@fractaledmind
Copy link

This code, in my testing, will have the dropdown appear on page load if minChars is set to 0. I doubt this is desirable behavior, so a more nuanced solution is probably needed.

@LeaVerou
Copy link
Owner

I would welcome that more nuanced solution :)
Closing this PR for now, since that’s a pretty major bug. Feel free to reopen if you want to extend it!
Thanks for contributing steelywing!

@LeaVerou LeaVerou closed this Nov 24, 2015
@LeaVerou
Copy link
Owner

Also, an easy temporary solution to anyone with this problem would be to fire a synthesized input event on their input.

@vlazar vlazar mentioned this pull request Nov 24, 2015
@vlazar
Copy link
Collaborator

vlazar commented Nov 30, 2015

@LeaVerou What is desired behavior on open(), on input focus and on page load when minChars is set to 0? See related #16761 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants