Expose xhr.abort() from Bliss.fetch(). #199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bliss.fetch()
returns a Promise, via which one cannot accessxhr.abort()
. This PR attaches the xhr to the promise, so one can call.abort()
. This is a little bit hacky ... but the HTML5 fetch API & abort stuff looks complicated and is experimental, so perhaps this PR is the best approach for now.Discussed in this issue: #198
Right now this PR includes only Bliss.Shy.js — shall I run some build script so the
.min.js
files get updated too, + update the "thick" Bliss js file too? Or do you want to do that (Lea) ?