Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose xhr.abort() from Bliss.fetch(). #199

Merged
merged 2 commits into from
Jul 19, 2017

Conversation

kajmagnus
Copy link
Contributor

Bliss.fetch() returns a Promise, via which one cannot access xhr.abort(). This PR attaches the xhr to the promise, so one can call .abort(). This is a little bit hacky ... but the HTML5 fetch API & abort stuff looks complicated and is experimental, so perhaps this PR is the best approach for now.

Discussed in this issue: #198

Right now this PR includes only Bliss.Shy.js — shall I run some build script so the .min.js files get updated too, + update the "thick" Bliss js file too? Or do you want to do that (Lea) ?

@LeaVerou
Copy link
Owner

No, just bliss.shy.js is ok. Could you shorten the comment? The part in the parentheses is obvious.
Also, could you please edit the documentation to mention this?
Thanks!

@kajmagnus
Copy link
Contributor Author

Ok, done. (What do you think?)

@LeaVerou LeaVerou merged commit 6bd9c06 into LeaVerou:gh-pages Jul 19, 2017
@LeaVerou
Copy link
Owner

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants