Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quote_type to editor config #56

Closed
wants to merge 1 commit into from
Closed

Add quote_type to editor config #56

wants to merge 1 commit into from

Conversation

jrandolf-2
Copy link
Collaborator

Because manual formatting is painful.

@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for parsel ready!

Name Link
🔨 Latest commit 7520ae3
🔍 Latest deploy log https://app.netlify.com/sites/parsel/deploys/64110efb817d3d0008d23a55
😎 Deploy Preview https://deploy-preview-56--parsel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@LeaVerou
Copy link
Owner

I see this config being quite minimal. How does Prettier deal with smart tabs?

The editor config is also read by prettier for formatting.
@jrandolf-2 jrandolf-2 changed the title Add prettier Add quote_type to editor config Mar 15, 2023
@jrandolf-2 jrandolf-2 changed the title Add quote_type to editor config Add quote_type to editor config Mar 15, 2023
@jrandolf-2
Copy link
Collaborator Author

Actually, I realized prettier reads from the .editorconfig for quote type, so we don't even need an editor config. A format suffices.

@jrandolf-2 jrandolf-2 closed this Mar 15, 2023
@jrandolf-2 jrandolf-2 removed the request for review from LeaVerou March 15, 2023 00:30
@jrandolf-2 jrandolf-2 deleted the add-prettier branch March 16, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants