Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for touch devices #1

Closed
wants to merge 1 commit into from
Closed

Quick fix for touch devices #1

wants to merge 1 commit into from

Conversation

pixelmord
Copy link

Do not disable pointer-events on pagination buttons

Do not disable pointer-events on pagination buttons
@LeaVerou
Copy link
Owner

Changes to CSSS should be made in its own repo, this is just a subtree.
Do note however that since there is no on-screen navigation on 99% of slides, this will not really help much…

@pixelmord
Copy link
Author

@LeaVerou As I said in my comment on your blog, I really had no time to really look into the issue. However since the slideshow of your talk is not working on an IPAD and possibly other touch devices, I just did this quick fix to improve a11y.
On the IPAD all the slides have on screen navigation, which makes sense because there is no swipe functionality built in afaik. However having the on screen navigation show won't be useful unless the touch event is fired. If you want to reproduce that issue without an Ipad you need to use the IOS simulator, because for some reason the chrome dev tools will have a more desktop like behaviour to distinguish between hover and touch.

Since I did not dig into your css so much to understand why you set the pointer-events: none I will better not do another PR on the other repo for CSSS, because just removing that could possibly break some other intention that you had.

So since you have no on-screen navigation on 99% of slides for THIS presentation on DESKTOP you could incorporate this as a preliminary fix to let people on a tablet get past the first slide and inspect the issue in more depth later in CSSS.

Have a good weekend!

@LeaVerou
Copy link
Owner

So you're fine making this change on a copy of the repo but not on the actual repo. WTF. But oook, your call. Bye!

@pixelmord
Copy link
Author

oO If I am reading your last comment correctly, you seam offended or infuriated.
That was not my intention at all, I just wanted to help. I like your work, that is why I ended up here trying to do so.
I am sorry to have failed in that and to communicate that well enough! May be one day we meet in person, I'll buy you a coffee and you will find out I am not the troll you take me for :)

Back to topic: I will close this PR and hope to find time to help you on the other repo.

@pixelmord pixelmord closed this Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants