-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Size of edit vertex (edit handle) is too big #692
Comments
0.4.9 fixes this issue.
…On Wed, Feb 15, 2017 at 5:50 AM, Mat Beard ***@***.***> wrote:
I've recently switched to the 1.0 release of Leaflet and Leaflet Draw
0.4.7 (installed via NPM). Now when drawing or editing, the size of the
editing vertex/handle is bigger than previously.
Inspecting the code reveals it's 20px x 20px, but this is hard-coded into
the element's style attribute, rather than the result of a CSS class.
I've fiddled with the styles and it appears that it used to be around a
quarter of the size (approx 10px x 10px).
Is the size of the edit handle easily configurable? The 'old' size was far
better in my opinion, but I'd like to avoid fiddling with the source.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#692>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAzNEp5wQ-stm2AApRs-nhxC_0tPnjDTks5rcwK1gaJpZM4MBvMk>
.
|
Hmm, I've upgraded to 0.4.9 and I still have the same issue. If I manually set |
I'm also experiencing the same issue as @matbeard on 0.4.9. Cannot finish polylines, and finishing polygons (clicking on the first point) only works sometimes. |
There's a couple of things that are broken if you set L.Browser.touch to false in 0.4.9
In any case, I don't think L.Browser.touch is really the right thing to use to determine the use of certain features. L.Browser.touch just says whether the browser is touch enabled, but you may not want that to be used, particularly for drawing. It would be better to have an option within Leaflet.Draw itself. |
I've had some success by also setting |
I've same issue as @matbeard with following user agent: Chrome on mac support touch event but it does not have touch screen. 20x20px handler not really needed Use |
Hi everyone, |
Any (clean) way to circumvent the issue? In Firefox/Chrome/Safari on macOS 11.6.3 the handles are way too big to be used with small(ish) polygons, because the handles overlap. Instead of 20px, ~8px or so would be enough. Sure I can hack the default values in the sources, but is there no overloading of these properties to get back to reasonable sizes of drag handlers of polygons? (Leaflet 1.7.1, Leaflet Draw 1.0.4): https://jsfiddle.net/7jr0ov2s/4/ |
still here, but the vertex size can be set with: |
I've recently switched to the 1.0 release of Leaflet and Leaflet Draw 0.4.7 (installed via NPM). Now when drawing or editing, the size of the editing vertex/handle is bigger than previously.
Inspecting the code reveals it's 20px x 20px, but this is hard-coded into the element's style attribute, rather than the result of a CSS class.
I've fiddled with the styles and it appears that it used to be around a quarter of the size (approx 10px x 10px).
Is the size of the edit handle easily configurable? The 'old' size was far better in my opinion, but I'd like to avoid fiddling with the source.
UPDATE: After a look in the source, it appears my implementation is defaulting to using the touchResizeIcon (20x20) rather than resizeIcon (8x8).
It seems touch is enabled based on browser rather than device:
so I've manually set L.Browser.touch to false, which has fixed the size of the edit vertex, but now I can no longer click on the last point of a LineString to finish the line!
The text was updated successfully, but these errors were encountered: