Implement fast zoom on minus/plus keydown with shiftKey #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Though I don't think there's a need to introduce a new option for this — there was never a need to customize shift-double-click on the zoom control so I don't think there will be need for it here. Less unused options -> better. |
|
OK, let me fix that then :) |
| @@ -141,7 +141,7 @@ L.Map.Keyboard = L.Handler.extend({ | |||
| } | |||
|
|
|||
| } else if (key in this._zoomKeys) { | |||
| map.setZoom(map.getZoom() + this._zoomKeys[key]); | |||
| map.setZoom(map.getZoom() + (e.shiftKey ? this._zoomKeys[key] * 3 : this._zoomKeys[key])); | |||
There was a problem hiding this comment.
more compactly written as ((e.shiftKey ? 3 : 1) * this._zoomKeys[key])
There was a problem hiding this comment.
Always with style :)
Done.
mourner
added a commit
that referenced
this pull request
Nov 14, 2014
Implement fast zoom on minus/plus keydown with shiftKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal is to make it consistent with the zoomControl shift+click.
If you think it's a good suggestion, I'm still not sure:
shiftZoomFactorwith zoomControlshiftZoomFactoroption at allThanks for reviewing :)