Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidebar tabs #2551

Merged

Conversation

roth-michael
Copy link
Contributor

Only real question here is whether I handled the playlist unknown -> Promise<InstanceType<ConfiguredDocumentClass<typeof Playlist>>> stuff right. I'm certain they return a Playlist type object, but not certain I've properly copy/pasted the appropriate types (i.e. vs just making them return Promise<Playlist>

@roth-michael roth-michael requested a review from a team as a code owner June 14, 2024 01:59
@JPMeehan
Copy link
Collaborator

Only real question here is whether I handled the playlist unknown -> Promise<InstanceType<ConfiguredDocumentClass<typeof Playlist>>> stuff right. I'm certain they return a Playlist type object, but not certain I've properly copy/pasted the appropriate types (i.e. vs just making them return Promise<Playlist>

One of the things I went through and did was added Document.ConfiguredInstance, e.g. Playlist.ConfiguredInstance, as a reference to the configured document type.

Copy link
Collaborator

@JPMeehan JPMeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller adjustments

@JPMeehan JPMeehan merged commit dbc39c2 into League-of-Foundry-Developers:v11/data-models Jun 14, 2024
0 of 3 checks passed
@roth-michael roth-michael deleted the sidebarTabs branch June 14, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants