Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON change notifications #21

Merged
merged 2 commits into from
Oct 5, 2021
Merged

JSON change notifications #21

merged 2 commits into from
Oct 5, 2021

Conversation

mkahvi
Copy link
Contributor

@mkahvi mkahvi commented Sep 29, 2021

Adds two options to be notified of either system JSON (system.json & template.json) changes or module JSON (module.json) changes.

The introduced code should be fairly easy to extend or fix in case there are other cases that I missed.

Copy link
Member

@akrigline akrigline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! A few changes but this is looking great.

module/hooks/json-changes.mjs Outdated Show resolved Hide resolved
module/hooks/json-changes.mjs Outdated Show resolved Hide resolved
module/hooks/json-changes.mjs Outdated Show resolved Hide resolved
foundryvtt-devMode.mjs Outdated Show resolved Hide resolved
Copy link
Member

@akrigline akrigline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@akrigline akrigline merged commit 32c80e6 into League-of-Foundry-Developers:main Oct 5, 2021
@mkahvi mkahvi deleted the json-change-notify branch October 6, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants