Skip to content
This repository has been archived by the owner on Sep 3, 2022. It is now read-only.

Resolve #5 -- Using the download from Google drive. Converts projects to x86 #6

Merged
merged 5 commits into from
Oct 23, 2020
Merged

Conversation

samuelGrahame
Copy link
Contributor

@samuelGrahame samuelGrahame commented Oct 3, 2020

Resolve #5

samfromdeath added 3 commits October 1, 2020 09:25
…you just paste the path when clicking download it will start extraction as soon as it has finished downloading. it will set the clipboard with the path.

i have also changed to set all projects to x86.
once visual studio has opened set startup project to gameserverconsole and it will start.
@CLAassistant
Copy link

CLAassistant commented Oct 3, 2020

CLA assistant check
All committers have signed the CLA.

@danil179 danil179 changed the title Using the download from Google drive. Converts projects to x86 Resolve #5 -- Using the download from Google drive. Converts projects to x86 Oct 4, 2020
Copy link
Contributor

@danil179 danil179 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

League Sandbox Auto Setup/leagueSandboxAutoSetupForm.cs Outdated Show resolved Hide resolved
League Sandbox Auto Setup/leagueSandboxAutoSetupForm.cs Outdated Show resolved Hide resolved
League Sandbox Auto Setup/leagueSandboxAutoSetupForm.cs Outdated Show resolved Hide resolved
League Sandbox Auto Setup/leagueSandboxAutoSetupForm.cs Outdated Show resolved Hide resolved
League Sandbox Auto Setup/leagueSandboxAutoSetupForm.cs Outdated Show resolved Hide resolved
startVisualStudioFirstRun();
return;
}

String testboxLink = "http://gamemakersgarage.com/LeagueUI.7z";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link will eventually break too. Not crucial. (I'll open an issue)

League Sandbox Auto Setup/appsettings.json Outdated Show resolved Hide resolved
League Sandbox Auto Setup/leagueSandboxAutoSetupForm.cs Outdated Show resolved Hide resolved
samfromdeath added 2 commits October 5, 2020 11:09
removed spaces
removed comments
moved _convertProjectsToX86 to top of class
renamed ater to after
Copy link
Contributor

@danil179 danil179 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is better than the current state. Approved.

@danil179 danil179 merged commit 9007a32 into LeagueSandbox:master Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server unavailable causes crash
3 participants