Added informative error format #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahmanor
reviewed
Sep 13, 2018
bin/tag-release-prerelease.js
Outdated
| @@ -12,6 +12,9 @@ commander.parse(process.argv); | |||
| let options = {}; | |||
| const { verbose, maxbuffer, args } = commander; | |||
| const prerelease = args.length ? args[0] : true; | |||
| options = extend({}, { prerelease, verbose, maxbuffer, workflow }); | |||
| options = extend( | |||
There was a problem hiding this comment.
I don't think the extend is needed here. You should just be able to do something like...
options = { prerelease, verbose, maxbuffer, workflow, command: "prerelease" };
elijahmanor
reviewed
Sep 13, 2018
bin/tag-release-promote.js
Outdated
| @@ -12,6 +12,9 @@ commander.parse(process.argv); | |||
| let options = {}; | |||
| const { verbose, maxbuffer, args } = commander; | |||
| const promote = args.length ? args[0] : true; | |||
| options = extend({}, { promote, verbose, maxbuffer, workflow }); | |||
| options = extend( | |||
elijahmanor
reviewed
Sep 13, 2018
bin/tag-release-qa.js
Outdated
| }; | ||
|
|
||
| let options = {}; | ||
| const { verbose, maxbuffer, args } = commander; | ||
| const qa = args.length ? args[0] : true; | ||
| options = extend({}, { qa, verbose, maxbuffer, callback, workflow }); | ||
| options = extend( | ||
| {}, |
elijahmanor
reviewed
Sep 13, 2018
bin/tag-release-reset.js
Outdated
| @@ -6,6 +6,6 @@ const workflow = require("../src/workflows/reset"); | |||
|
|
|||
| commander.parse(process.argv); | |||
|
|
|||
| const options = extend({}, { reset: true, workflow }); | |||
| const options = extend({}, { reset: true, workflow, command: "reset" }); | |||
elijahmanor
reviewed
Sep 13, 2018
bin/tag-release-start.js
Outdated
| @@ -10,6 +10,6 @@ utils.applyCommanderOptions(commander); | |||
| commander.parse(process.argv); | |||
|
|
|||
| const { verbose, maxbuffer } = commander; | |||
| const options = extend({}, { verbose, maxbuffer, workflow }); | |||
| const options = extend({}, { verbose, maxbuffer, workflow, command: "start" }); | |||
elijahmanor
reviewed
Sep 13, 2018
specs/helpers/setup.spec.js
Outdated
| state = {}; | ||
| }); | ||
|
|
||
| afterEach(() => { |
There was a problem hiding this comment.
I think you can remove the afterEach here since the beforeEach will run before each test. You should have a fresh start each time
elijahmanor
reviewed
Sep 13, 2018
specs/workflows/steps/index.spec.js
Outdated
| @@ -73,7 +73,9 @@ describe("shared workflow steps", () => { | |||
| }); | |||
|
|
|||
| afterEach(() => { | |||
| state = {}; | |||
| state = { | |||
There was a problem hiding this comment.
Can you move this code into the beforeEach and remove this afterEach?
elijahmanor
requested changes
Sep 14, 2018
src/helpers/runWorkflow.js
Outdated
| command: ${options.command} | ||
| step: ${options.step} | ||
| error: ${error.message}`; | ||
| utils.writeFile(logPath, content); |
There was a problem hiding this comment.
This could just be...
const fs = require("fs");
fs.appendFileSync(logPath, content);
Then you could remove lines 9-12. At some point in the future maybe you could pull that out to a utils.appendFile method, but for now I'm find if you just use fs directly since the API is the same. It could be refactored in a following PR and update the other places you mentioned that could benefit for appendFile instead of writing the whole thing again
src/workflows/steps/index.js
Outdated
| @@ -88,6 +88,7 @@ const api = { | |||
| }, | |||
| fetchUpstream(state) { | |||
| state.step = "fetchUpstream"; | |||
| // return Promise.reject(new Error("something bad")); | |||
RobertReaves
force-pushed
the
feature-beautiful-errors
branch
from
ce585f6
to
f5759be
Compare
elijahmanor
approved these changes
Sep 14, 2018
elijahmanor
approved these changes
Sep 14, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the work completed
Steps to test (if not obvious)
For Reviewer Use Only
src/help.jsandREADME.mdpatch)