Convert member role to learner role. Add default phase to new users who are learners. #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyheyjp
requested changes
Aug 28, 2017
|
|
||
| expect(member).to.exist | ||
| expect(member.chapterId).to.eq(this.chapter.id, 'member should have chapter ID for invite code') | ||
| // TODO: fix - should assert github service function called w/ correct args |
There was a problem hiding this comment.
Please do add at least one assertion about a github service function being called.
src/server/workers/userCreated.js
Outdated
| if (idmUser.roles.includes(LEARNER)) { | ||
| const defaultPhase = (await Phase.getAll(DEFAULT_PHASE_NUMBER, {index: 'number'}))[0] | ||
| if (!defaultPhase) { | ||
| throw new Error('Phase not found for default numberL', DEFAULT_PHASE_NUMBER) |
sdweber422
force-pushed
the
1079-convert-member-to-learner
branch
from
235bf6a
to
cf7f541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1079.
Fixes #1080.
Overview
Converted roles where 'member' existed and replaced it with 'learner'. Added default phase when creating a new user who has the learner role in userCreated worker.
Data Model / DB Schema Changes
User model roles changed from 'member' to 'learner'.
Environment / Configuration Changes
None.
Notes