LCU Rest Client Error on empty OK 200 response because of json deserlization error #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lid json return Ok(serde_json::Value::Null) instead if an Err(...)
|
im not at my setup atm to test but i believe in you |
|
Also you make a lot of prs and i havent really had much time to maintain this library, would you like me to give you maintainer access? |
|
Nah, it's fine. I don't mind contributing via the PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the LCU-Rest-Client receives OK 200 with an empty response or invalid json return Ok(serde_json::Value::Null) instead if an Err(...)