Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unstable dependency on swift-checkit. #22

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Conversation

furby-tm
Copy link
Contributor

@furby-tm furby-tm commented Dec 9, 2023

Hey there!

In your swift package, you have what SwiftPM classifies as an "unstable version" on the swift-checkit dependency. SwiftPM is exceptionally strict on versioning requirements of packages that hold dependencies of packages that have "unstable versions".

The main issue with this, is that it disallows any Swift package which includes your dependency from being able to tag a release version on their own packages, with a SwiftPM error in the form of:

error: Dependencies could not be resolved because root depends on 'consumer-of-tomlkit'
'consumer-of-tomlkit' cannot be used because package 'consumer-of-tomlkit' is required using a stable-version but 'consumer-of-tomlkit' depends on an unstable-version package 'tomlkit'

I have provided the simple fix to tag the 0.0.2 release of swift-checkit, which is even with the master branch of swift-checkit at the time of writing.

Thank you!

furby-tm added a commit to furby-tm/swift-bundler that referenced this pull request Dec 9, 2023
* Note, I have set this to my fork which has an additional fix to TOMLKit - pending a PR.
* PR: LebJe/TOMLKit#22
@LebJe
Copy link
Owner

LebJe commented Dec 10, 2023

Thank you! Can you please update Package@swift-5.5.swift as well?

stackotter pushed a commit to stackotter/swift-bundler that referenced this pull request Dec 10, 2023
* Create a swift bundler command line plugin.

* Remove unused plugin conformance to XcodeCommandPlugin.

* Set TOMLKit version to @furby-tm fork pending PR.
* Note, I have set this to my fork which has an additional fix to TOMLKit - pending a PR.
* PR: LebJe/TOMLKit#22

* Resolve TOMLKit package dependency.
@furby-tm
Copy link
Contributor Author

Should be all set! 🤘🏻

@LebJe LebJe merged commit 2836432 into LebJe:main Dec 10, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants