Fix: Prevent crash on noise effect with single pixel virtual

[bigredfrog]

Improve the dimension control by using slicing instead of squeeze to enforce 2 dimensions

Summary by CodeRabbit

• Refactor
  • Optimized array generation, simplified noise dimension handling, and improved color space manipulation for noise visualization.

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: ledfx/effects/noise2d.py

Function	Unhandled Issue
draw	ValueError: axes don't match array ledfx.effects.... Event Count: 9
draw	ValueError: axes don't match array threading in run Event Count: 8

---

_{Did you find this useful? React with a 👍 or 👎}

[coderabbitai]

Walkthrough

The recent updates aim to enhance the performance and clarity of the codebase by removing redundant logging, optimizing array operations, and refining the handling of noise dimensions and color space adjustments. These changes collectively improve the efficiency and visual output quality of the software.

Changes

File Path	Change Summary
ledfx/effects/noise2d.py	Optimized array generation, simplified noise dimension handling, improved color space manipulation for noise visualization.

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 558a86b and a973f98.

Files selected for processing (1)

• ledfx/effects/noise2d.py (4 hunks)

Files skipped from review as they are similar to previous changes (1)

• ledfx/effects/noise2d.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)

ledfx/effects/noise2d.py (1)

Line range hint 3-3: The timeit module is imported but not used in the file.

- import timeit

[coderabbitai]

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)

ledfx/effects/noise2d.py (1)

Line range hint 3-3: Remove unused import timeit.

- import timeit