[LL-8097] sell/fund flow

[ghost]

🦒 Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LL-8097
https://ledgerhq.atlassian.net/browse/LL-8101
https://ledgerhq.atlassian.net/browse/LL-8105

Add the exchange SELL and FUND flow in the context of the live-app-sdk.

It is built on the fondations laid down by this POC PR by @juan-cortes

🔗 LedgerHQ/ledger-live-common#1486

💻 Description / Demo (image or video)

This PR provide the minimal technical requirements to handle exchange-app flow in the SDK context within LLD.
No consideration has been made regarding UI design / modals. As of today the displayed modal is a minimalistic one that could be improved in subsequent iterations.

• Integrate the sell flow in the SDK context to LLD
• Integrate the fund flow in the SDK context to LLD

🖤 Expectations to reach

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

• on QA: at least one of these two checkboxes must be checked:
  • a specific test planned is defined on Jira
  • this PR is covered by automatic UI test
• on delivery: at least one of these two checkboxes must be checked:
  • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
  • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

🧪 How to test

Sell flow

• start the Coinify live app POC locally (yarn dev)
• in the developer tab in the settings, upload the associated manifest (cf. bellow 👇)
• open the POC live app in LLD and test the sell flow

Fund flow

Same steps as above but instead of the Coinify live app POC, use this platform-app-test-exchange instead.

PS: You will need a test version of the exchange app to test the fund flow, cf. the platform-app-test-exchange README for details

---

Here is a reference of the manifest file referenced in previous tests sections

This manifest assumes your local Live App runs on http://localhost:3000. If this is not the case, update the url field accordingly in your manifest

Local live app manifest (.json file)

{
  "id": "test-app",
  "name": "Test app",
  "url": "http://localhost:3000",
  "homepageUrl": "https://developers.ledger.com/",
  "icon": "",
  "platform": "all",
  "apiVersion": "0.0.1",
  "manifestVersion": "1",
  "branch": "debug",
  "categories": ["tools"],
  "currencies": "*",
  "content": {
    "shortDescription": {
      "en": "Test Live App. Use at your own risk."
    },
    "description": {
      "en": "Test Live App. Use at your own risk."
    }
  },
  "permissions": [
    {
      "method": "*"
    }
  ],
  "domains": ["https://*"]
}

☑️ Todo

• rebase once live-common 21.29.0 #4663 merged

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🔴	Statements	8.74%	9/103
🔴	Branches	0%	0/19
🔴	Functions	2.94%	1/34
🔴	Lines	8.33%	8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 9cd1bca

[ggilchrist-ledger]

Why not in the case statement?

[chabroA]

What do you mean exactly?

[ggilchrist-ledger]

Just wondering why you have the conditional statement within the 0x02 case

[ggilchrist-ledger]

Is it just less lines of code rather than writing the return statement in both the 0x01 and the 0x02 statements?

[chabroA]

Yes, it avoids code duplication.
FYI it is not only within the 0x02 case, but also within the 0x01 case (cf. -> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/switch#methods_for_multi-criteria_case)

[juan-cortes]

lgtm, I was sure I already approved this last week 😕

[LFBarreto]

LGTM however i suggest you start thinking of moving all of that device action specific towards Live-common
this feels way too logic oriented to be on the "front" part.
especially when you're managing hex codes directly 🙈