fix: webview usage with electron 22 #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert ":fire: hotfix release [skip ci]" This reverts commit e0e5bb6. * Revert ":fire: hotfix prerelease [LLD(2.51.0-hotfix.0)]" This reverts commit 252aa67. * Revert ":rocket: entering LLD hotfix mode" This reverts commit 8f708eb. * Revert ":fire: hotfix release [skip ci]" This reverts commit 4ca8f86. * Revert "Update wording" This reverts commit fea165d. * Revert "add energy lt for warning message to be display" This reverts commit 693e44e. * Revert "add more feelimit to tron trc20" This reverts commit 1910b23. * Revert ":fire: hotfix prerelease [LLM(3.12.0)]" This reverts commit de77a92. * Revert ":rocket: entering LLM hotfix mode" This reverts commit 42df4fc.
[support] Manually merge hotfix to main
…2122) * Fix start of post onboarding not being called in the right place * changeset
Add blockcerts BCERT token icon
Removed the complex file, verifying the file can be converted to react native, verifying the requirements are present and avoid what is prohibited.
Added the latest requirements and removed what was asked to remove
feat - show DEX quotes on LLD Swap screen
🦋 Changeset detectedLatest commit: 0809051 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
automation
Codecov ReportBase: 0.00% // Head: 45.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feat/electron-22 #2182 +/- ##
=====================================================
+ Coverage 0 45.94% +45.94%
=====================================================
Files 0 740 +740
Lines 0 31929 +31929
Branches 0 8368 +8368
=====================================================
+ Hits 0 14669 +14669
- Misses 0 15937 +15937
- Partials 0 1323 +1323
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Screenshots: ❌
It seems this PR contains screenshots that are different from the base branch.
windows
|
|
/generate-screenshots |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Description from: #1777
cf. https://ledgerhq.atlassian.net/browse/LIVE-4335?focusedCommentId=247299
In a breaking change in Electron 18 the nativeWindowOpen web preference (used here) have been removed (cf. this PR)
Now, Ledger live does not seem to receive (and handle) new-window events when a live-apps wants to open a new window (regularly used throughout Live Apps to open external contextual info like redirect to Twitter account, open ToS page, etc…)
webvieware deprecated and not formerly integrated / maintained in electron.updating electron broke previous handleding of new window opened from a
webviewuse
setWindowOpenHandleron thewebviewwebContents to handle opening new window.cf. electron/electron#31117 (comment)
also, there seem to be issues between
webviewand Reactcf. electron/electron#6046
PS: this solution works as is. It might not be the most beautiful. Feel free to use it as a base version and improve on it if need be.
❓ Context
ledger-live-mobile,ledger-live-desktop✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.