Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 💄 Update Copy of LedgerSync #7853

Merged
merged 1 commit into from
Sep 20, 2024
Merged

feat: 💄 Update Copy of LedgerSync #7853

merged 1 commit into from
Sep 20, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 19, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Update whole flow with new Figma

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner September 19, 2024 13:41
@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 2:21pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 2:21pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 2:21pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 2:21pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 2:21pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Sep 19, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit 2fd05ea into develop Sep 20, 2024
41 of 42 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the feat/update-ledgerSync-copy-llm branch September 20, 2024 09:45
mohamedzitouni added a commit that referenced this pull request Sep 23, 2024
@mohamedzitouni
Updating success text locator due to update on wording #7853
705cff9
mohamedzitouni added a commit that referenced this pull request Sep 23, 2024
@mohamedzitouni
Updating locators on success screen and key deletion due to an update…
be1d33b 
… on wording #7853 (#7877)

* Updating success text locator due to update on wording #7853

* Update text on locator

* Fixing prettier
qperrot pushed a commit that referenced this pull request Sep 25, 2024
@mohamedzitouni @qperrot
Updating locators on success screen and key deletion due to an update…
e23c7ec 
… on wording #7853 (#7877)

* Updating success text locator due to update on wording #7853

* Update text on locator

* Fixing prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasWerey LucasWerey LucasWerey approved these changes

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcayuelas-ledger @LucasWerey