Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(llm): 🚦 create llmMemoTag feature flag #7963

Merged
merged 2 commits into from
Oct 2, 2024
Merged

chore(llm): 🚦 create llmMemoTag feature flag #7963

merged 2 commits into from
Oct 2, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Oct 1, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Just adds llmMemoTag feature flag. Which is disabled by default.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner October 1, 2024 14:56
@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 1, 2024 2:56pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 1, 2024 2:56pm
native-ui-storybook ⬜️ Ignored (Inspect) Oct 1, 2024 2:56pm
react-ui-storybook ⬜️ Ignored (Inspect) Oct 1, 2024 2:56pm
web-tools ⬜️ Ignored (Inspect) Oct 1, 2024 2:56pm

@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Oct 1, 2024
@thesan thesan merged commit 642c714 into develop Oct 2, 2024
58 of 60 checks passed
@thesan thesan deleted the chore/llm-memo-tag-ff branch October 2, 2024 09:25
VicAlbr pushed a commit that referenced this pull request Oct 2, 2024
@thesan @VicAlbr
chore(llm): 🚦 create llmMemoTag feature flag (#7963)
344dd43 
* chore(llm): create `llmMemoTag`

* chore: update change log
angusbayley pushed a commit that referenced this pull request Oct 2, 2024
@thesan @angusbayley
chore(llm): 🚦 create llmMemoTag feature flag (#7963)
4b3813f 
* chore(llm): create `llmMemoTag`

* chore: update change log
VicAlbr pushed a commit that referenced this pull request Oct 2, 2024
@thesan @VicAlbr
chore(llm): 🚦 create llmMemoTag feature flag (#7963)
fe2e9e5 
* chore(llm): create `llmMemoTag`

* chore: update change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasWerey LucasWerey LucasWerey approved these changes

Assignees

@thesan thesan

Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesan @LucasWerey