Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ledger key ring protocol #7964

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Oct 1, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Use the name Ledger Key Ring Protocol for our libraries

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Oct 1, 2024
@KVNLS KVNLS requested a review from a team as a code owner October 1, 2024 14:58
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 1, 2024 3:05pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 1, 2024 3:05pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 1, 2024 3:05pm
native-ui-storybook ⬜️ Ignored (Inspect) Oct 1, 2024 3:05pm
react-ui-storybook ⬜️ Ignored (Inspect) Oct 1, 2024 3:05pm

@KVNLS KVNLS merged commit 0162b42 into develop Oct 2, 2024
58 checks passed
@KVNLS KVNLS deleted the fix/rename-ledger-key-ring-protocol branch October 2, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants