Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support/fix ada fees #7965

Merged
merged 21 commits into from
Oct 2, 2024
Merged

Support/fix ada fees #7965

merged 21 commits into from
Oct 2, 2024

Conversation

hedi-edelbloute
Copy link
Member

@hedi-edelbloute hedi-edelbloute commented Oct 1, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Src PR : #7930

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

pavanvora and others added 17 commits September 25, 2024 22:02
@pavanvora
cardano high fees checks
cab382b
@pavanvora
add custom CardanoFeeTooHigh error
9413545
@Prashanthsoordelu
display feeTooHigh error
cb07b22
@pavanvora
Merge pull request #30 from Prashanthsoordelu/bugfix/cardano-tx-fees
3a507c9 
display feeTooHigh error
@pavanvora
validate protocol params
333a1f3
@Prashanthsoordelu
handle fee error in delegation
0b2fe8c
@pavanvora
Merge pull request #31 from Prashanthsoordelu/bugfix/cardano-tx-fees
3d5a81d 
handle fee error in delegation
@Prashanthsoordelu
fee warning in delegation
15c708a
@pavanvora
Merge pull request #32 from Prashanthsoordelu/bugfix/cardano-tx-fees
b980cb6 
fee warning in delegation
@mehulcs
show tx status warnings and errors
891b8cb
@pavanvora
Merge pull request #33 from mehulcs/tx-errors-warnings
8ad5b5f 
show tx status warnings and errors
@Prashanthsoordelu
update
0237eba
@pavanvora
Merge pull request #34 from Prashanthsoordelu/bugfix/cardano-tx-fees
225305b 
update
@mehulcs
tx error update
53d5c57
@pavanvora
Merge pull request #35 from mehulcs/error-update
ba826d9 
tx error update
@pavanvora
sync proto params in tx prepare
a1f243f
@hedi-edelbloute
Merge pull request #7930 from StricaHQ/bugfix/cardano-tx-fees
076e1e0 
Bugfix/cardano sync check
@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 10:30am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 10:30am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 10:30am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 10:30am
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 10:30am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Oct 1, 2024
@live-github-bot live-github-bot bot added the common Has changes in live-common label Oct 1, 2024
@hedi-edelbloute hedi-edelbloute marked this pull request as ready for review October 2, 2024 10:27
@hedi-edelbloute hedi-edelbloute requested a review from a team as a code owner October 2, 2024 10:27
@hedi-edelbloute hedi-edelbloute merged commit 07a242d into develop Oct 2, 2024
53 of 62 checks passed
@hedi-edelbloute hedi-edelbloute deleted the support/fix-ada-fees branch October 2, 2024 14:03
hedi-edelbloute added a commit that referenced this pull request Oct 2, 2024
@hedi-edelbloute @pavanvora
@Prashanthsoordelu @mehulcs
Support/fix ada fees (#7965)
77adfc3 
* cardano high fees checks

* add custom CardanoFeeTooHigh error

* display feeTooHigh error

* validate protocol params

* handle fee error in delegation

* fee warning in delegation

* show tx status warnings and errors

* update

* tx error update

* sync proto params in tx prepare

* add coinconfig + update translations

* fix cc

* update texts

* add changeset

---------

Co-authored-by: pavanvora <pavanvora.cs@gmail.com>
Co-authored-by: Prashanth <prashanthsoordelu@gmail.com>
Co-authored-by: Pavan Vora <pavanvora@users.noreply.github.com>
Co-authored-by: mehulcs <mehul.becs@gmail.com>
@hedi-edelbloute hedi-edelbloute mentioned this pull request Oct 2, 2024
Merged
3 tasks
hedi-edelbloute added a commit that referenced this pull request Oct 2, 2024
@hedi-edelbloute
Merge pull request #7978 from LedgerHQ/support/add-cardano-fees-fix
aa56d4b 
Support/fix ada fees (#7965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wozacosta Wozacosta Wozacosta approved these changes

Assignees

@hedi-edelbloute hedi-edelbloute

Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hedi-edelbloute @Wozacosta @pavanvora @Prashanthsoordelu @mehulcs