Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/live 8014 llm custom button #8032

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

qperrot
Copy link
Contributor

@qperrot qperrot commented Oct 7, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Modified common.json to add "addCustomValidator": "+ Add custom validator" so it will be translated.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@qperrot qperrot requested a review from a team as a code owner October 7, 2024 11:56
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 7, 2024 11:56am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 7, 2024 11:56am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 11:56am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 11:56am
web-tools ⬜️ Ignored (Inspect) Oct 7, 2024 11:56am

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Oct 7, 2024
@qperrot qperrot requested a review from Wozacosta October 7, 2024 11:57
@qperrot qperrot merged commit 2608451 into develop Oct 9, 2024
42 of 53 checks passed
@qperrot qperrot deleted the bugfix/LIVE-8014-LLM-custom-button branch October 9, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants