Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up unused string ids propagation for screenshots generation #653

Merged
merged 2 commits into from
May 13, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to clean-up unused string id propagation when generating screenshots.
The string ids are now directly retrieved from the strings.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • [*] Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.92%. Comparing base (66ebb82) to head (430fd39).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   59.92%   59.92%           
=======================================
  Files          12       12           
  Lines        1682     1682           
=======================================
  Hits         1008     1008           
  Misses        674      674           
Flag Coverage Δ
unittests 59.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger force-pushed the clean-unused-string-ids-propagation branch from 430fd39 to c9ffe9e Compare May 13, 2024 14:34
@nroggeman-ledger nroggeman-ledger merged commit 765cb53 into master May 13, 2024
192 checks passed
@nroggeman-ledger nroggeman-ledger deleted the clean-unused-string-ids-propagation branch May 13, 2024 14:42
@lpascal-ledger lpascal-ledger mentioned this pull request May 16, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants