This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Feature/timestamp #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gre
suggested changes
Feb 5, 2018
packages/hw-app-btc/src/Btc.js
Outdated
| this.toHexDigit((number >> 8) & 0xff) + | ||
| this.toHexDigit(number & 0xff) | ||
| ); | ||
| }; |
There was a problem hiding this comment.
can these 2 be implemented using Buffer instead?
something like buffer=Buffer.alloc(4); buffer.writeUInt32LE(number, 0); return buffer.toString("hex") (not tested) ?
There was a problem hiding this comment.
Yes, I was just transcribing the code (not trying to improve it right away). I'll fix it.
packages/hw-app-btc/src/Btc.js
Outdated
| .reverse() | ||
| .join(""), | ||
| "hex" | ||
| )) |
There was a problem hiding this comment.
I think it's better if we can directly create the Buffer with the number. without using a temporary string conversion
amougel
force-pushed
the
feature/timestamp
branch
12 times, most recently
from
1662b71
to
1384381
Compare
amougel
force-pushed
the
feature/timestamp
branch
from
1384381
to
914debe
Compare
gre
approved these changes
Feb 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding timestamp management to prepare for future altcoins integration