Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Fix invalid ChainID when it intersects with APDU boundary #644

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Aug 11, 2021

This PR is based off of #636 's work. Unfortunately it's on a remote to which I don't have the access to, so I'm creating this PR with Hector's commit and building on top of it.
This PR:

  • Fixes the problem when 4 byte chainID intesects with the APDU boundary
  • Fixes the test apdus (since the first commit changes the way ledgerjs generates apdus in certain cases).
  • Rename rlpOffset to vrsOffset to code readibility.

Closes #636

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #644 (5899789) into master (031cf51) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #644   +/-   ##
=======================================
  Coverage   40.93%   40.93%           
=======================================
  Files          74       74           
  Lines        4397     4397           
  Branches      720      720           
=======================================
  Hits         1800     1800           
  Misses       2580     2580           
  Partials       17       17           
Impacted Files Coverage Δ
packages/hw-app-eth/src/Eth.ts 85.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031cf51...5899789. Read the comment docs.

@gre gre merged commit d3675af into LedgerHQ:master Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants