This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Fix an issue with ERC20 info when using EIP 1559 transactions #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 40.91% 40.93% +0.02%
==========================================
Files 74 74
Lines 4407 4409 +2
Branches 721 723 +2
==========================================
+ Hits 1803 1805 +2
- Misses 2587 2590 +3
+ Partials 17 14 -3
Continue to review full report at Codecov.
|
pscott
suggested changes
Sep 2, 2021
packages/hw-app-eth/src/Eth.ts
Outdated
| decodedTx = { | ||
| data: rlpDecoded[5], | ||
| to: rlpDecoded[3], | ||
| chainId: rlpTx[6], |
There was a problem hiding this comment.
rlpTx[6] is only valid for post EIP-155 transactions (see https://eips.ethereum.org/EIPS/eip-155)
If rlpTx.length < 6 then the chainId should default to 1 :)
There was a problem hiding this comment.
Will change 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix an issue where ERC20 information wasn't provided to the Ledger when using EIP 1559 transactions!
Looks to work, but might need a sanity check 😄