Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Fixes README typos #782

Closed
wants to merge 1 commit into from
Closed

Fixes README typos #782

wants to merge 1 commit into from

Conversation

jritchie-nullable
Copy link

  • fixes references to Algorand
  • fixes typo
  • updates BIP 32 path

@jritchie-nullable
Fixes README typos
d3736e1 
- fixes references to Algorand
- fixes typo
- updates BIP 32 path
@jritchie-nullable jritchie-nullable requested a review from a team as a code owner January 29, 2022 01:56
@jritchie-nullable jritchie-nullable mentioned this pull request Jan 29, 2022
Open
@jritchie-nullable
Copy link
Author

#781

ghost
ghost approved these changes Jan 31, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #782 (d3736e1) into master (39ff487) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   43.51%   43.51%           
=======================================
  Files          81       81           
  Lines        4883     4883           
  Branches      859      859           
=======================================
  Hits         2125     2125           
  Misses       2744     2744           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ff487...d3736e1. Read the comment docs.

ghost
ghost suggested changes Jan 31, 2022
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure, need to figure it out...
@gre if you have an idea?

@gre
Copy link
Contributor

gre commented Jan 31, 2022

the doc is generated from the code, the typo are in comment of the code.

@gre
Copy link
Contributor

gre commented Jan 31, 2022

if you run yarn doc it will regenerate it. but the root issue is at

ledgerjs/packages/hw-app-algorand/src/Algorand.ts

Line 35 in d3736e1

* Cosmos API

@gre
Copy link
Contributor

gre commented Jan 31, 2022

I'll take it

@gre gre closed this in f772a6c Jan 31, 2022
@jritchie-nullable jritchie-nullable deleted the issue_781 branch February 1, 2022 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jritchie-nullable @gre