Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bitcoin.getAddress and bitcoin.getPublicKey [LIVE-14300] #393

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

Justkant
Copy link
Collaborator

@Justkant Justkant commented Oct 8, 2024

Add bitcoin.getAddress and bitcoin.getPublicKey methods to simplify live apps code

https://ledgerhq.atlassian.net/wiki/spaces/TA/pages/5038735412/ARCH+Acre+needs+requirements#Bitcoin-module-update

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wallet-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 8:33am
wallet-api-wallet-api-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 8:33am

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 7296b54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@ledgerhq/wallet-api-tools Minor
@ledgerhq/wallet-api-simulator Minor
@ledgerhq/wallet-api-client Minor
@ledgerhq/wallet-api-server Minor
@ledgerhq/wallet-api-core Minor
@ledgerhq/client-nextjs Patch
@ledgerhq/wallet-api-client-react Patch
@ledgerhq/wallet-api-manifest-validator-cli Patch
@ledgerhq/wallet-api-manifest-validator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -53,6 +53,78 @@ const profileWithFakeCurrency = {
};

describe("Simulator", () => {
describe("bitcoin.getAddress", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing that you added a test 👍

Copy link
Contributor

@ComradeAERGO ComradeAERGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Justkant Justkant merged commit 9261475 into main Oct 8, 2024
9 checks passed
@Justkant Justkant deleted the feat/LIVE-14300 branch October 8, 2024 09:52
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants