Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support creating scenes with controller trigger #74

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Support creating scenes with controller trigger #74

merged 3 commits into from
Apr 26, 2024

Conversation

bjorncs
Copy link
Contributor

@bjorncs bjorncs commented Apr 24, 2024

No description provided.

@bjorncs bjorncs mentioned this pull request Apr 24, 2024
Closed
slajob
slajob reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@slajob slajob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got some errors in validation. Please check it again. Maybe mentioned properties should be Optional

src/dirigera/devices/scene.py Show resolved Hide resolved
src/dirigera/devices/scene.py Outdated Show resolved Hide resolved
@slajob
Copy link
Contributor

slajob commented Apr 25, 2024

Now working well. Can be merged

Leggin
Leggin approved these changes Apr 26, 2024
View reviewed changes
Copy link
Owner

@Leggin Leggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool stuff thank you!

@Leggin Leggin merged commit e1f5692 into Leggin:main Apr 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slajob slajob slajob left review comments

@Leggin Leggin Leggin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjorncs @slajob @Leggin