Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress indicator in tar2sqlite #19

Merged
merged 3 commits into from
Nov 21, 2017
Merged

Add progress indicator in tar2sqlite #19

merged 3 commits into from
Nov 21, 2017

Conversation

mdamien
Copy link
Contributor

@mdamien mdamien commented Aug 22, 2017 •
edited
Loading

The script was taking time to process the archives so I added a small indicator to show that things aren't stuck.

Also, I tried bulk insertion in sqlite3 via BEGIN TRANSACTION...COMMIT but couldn't make it work. Trying PRAGMA synchronous = OFF when I have time

Changaco
Changaco requested changes Nov 21, 2017
View reviewed changes
Copy link
Member

@Changaco Changaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finally tested this, it works fine as expected, however I would prefer it to be optional, i.e. the script shouldn't fail with an ImportError if tqdm isn't installed.

@mdamien
Copy link
Contributor Author

mdamien commented Nov 21, 2017

thanks @Changaco, I've made it optional

@Changaco Changaco merged commit 4f6dc87 into Legilibre:master Nov 21, 2017
@Changaco
Copy link
Member

Thanks for contributing @mdamien. 🙂

Seb35 pushed a commit to Seb35/legi.py that referenced this pull request Jan 8, 2020
@adipasquale
Merge pull request Legilibre#19 from SocialGouv/legixplore-js
ea6a158 
Legixplore js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Changaco Changaco Changaco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdamien @Changaco