Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll bars #3

Merged
merged 5 commits into from
Oct 29, 2014
Merged

Scroll bars #3

merged 5 commits into from
Oct 29, 2014

Conversation

critor
Copy link
Contributor

@critor critor commented Oct 27, 2014

Here are some basic scrollbars for the end user.

For the moment, they are permanently displayed if the document is greater than the screen.

Todo: auto-hide the scrollbars once there is no new event requiring a redraw (scroll/zoom).

@Legimet
Copy link
Owner

Legimet commented Oct 27, 2014

OK, I'll test it. The auto-hiding of the scroll bar could be a setting. Some people may want the scroll bar displayed all the at all times.

@critor
Copy link
Contributor Author

critor commented Oct 27, 2014

Fixed a bug with the gray fillRects (wrong coordinates if page was smaller than the screen in height).

Fixed an out-of-bounds bug which was clearly visible thanks to the scrollbars.
Page position was not checked/fixed in case of a zoom in/out.

@adriweb adriweb mentioned this pull request Oct 27, 2014
@Legimet Legimet merged commit 5f3e9c0 into Legimet:master Oct 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants