Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Plugin #38

Merged
merged 6 commits into from
Jul 26, 2015
Merged

Conversation

OdNairy
Copy link
Contributor

@OdNairy OdNairy commented Jul 20, 2015

Applications List task
There are new plugin which presents list of installed applications separated by category (User, System, Internal). Internal apps group wouldn't show until any of internal apps will be find.
Each application object leads to LSApplicationProxy - private class representing application installation. You can find a lot of useful information about application from it.

@Legoless
Copy link
Owner

Hey, thanks for this. I'll review the code in the evening. But first Travis needs to pass. I'll check it out.

@OdNairy
Copy link
Contributor Author

OdNairy commented Jul 20, 2015

I'm working on it right now. I on Xcode 7 right now so some keywords still not available for Travis.

@Legoless
Copy link
Owner

This looks pretty good, the only thing I would ask you before merging is to rename the plugin to fit better with the rest. Now you called the plugin Applications List and in code you use AppsList. Could you change the folder to Application and classes to use ALPHAApplicationPlugin name and ALPHAApplicationSource instead of ALPHAAppsListSource. The icon should be renamed to ALPHAApplicationIcon.

Thanks.

@OdNairy OdNairy changed the title Applications List Plugin Application Plugin Jul 24, 2015
Legoless added a commit that referenced this pull request Jul 26, 2015
@Legoless Legoless merged commit 1884dc7 into Legoless:master Jul 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants