Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Default Light and Dark themes for instances #694

Open
comfy-v opened this issue Jun 23, 2022 · 3 comments
Open

Custom Default Light and Dark themes for instances #694

comfy-v opened this issue Jun 23, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@comfy-v
Copy link

comfy-v commented Jun 23, 2022

In order to customize a community, theming is important. By default, lemmy-ui has a light and dark theme, chosen depending on the user browser's preference. However, if an instance wants to change theme, they can only chose a single theme for either light and dark modes.

Consider an example on lemmygrad.ml, which has a red variant of both litely and darkly. However, they are forced to select one of them (they chose red-litely) causing a user used to one of the modes to note their discomfort.

Describe the solution you'd like

I do not administrate an instance or have a test, but I assume there is a dropdown option for an administrator to select the instance's default theme. I would like there to be two options, one for a default light theme and one for a default dark theme.

@comfy-v comfy-v added the enhancement New feature or request label Jun 23, 2022
@comfy-v comfy-v changed the title Custom Default Light and Dark themes Custom Default Light and Dark themes for instances Jun 23, 2022
@Nutomic
Copy link
Member

Nutomic commented Jun 27, 2022

I believe this already works. If you set theme "browser default" under /admin, users will get the light/dark theme based on browser preferences. At the same time, custom themes are given preference over builtin themes. So if you add your custom themes with the same filenames (darkly.css and litely.css) it should work like you describe. However, this will make it impossible to use the original darkly/litely themes, so it could be improved.

@dessalines
Copy link
Member

dessalines commented Jul 5, 2022

I do see the value in adding light and dark versions when using a custom default theme I spose. Although this might be overkill... not sure.

@Artoria2e5
Copy link

Artoria2e5 commented Jul 1, 2023

It would be great to have a paired theme switch where you define which theme is used for light and which one is for dark, preferably on a per-user basis. Maybe split the theme section into two and let the user set what to use when light and dark separately; there can always be a dummy option to say "use whatever light is using" to turn off the switch.

I would love to use such a feature when a pair of high-contrast themes become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants