Feature add three six and nine months options frontend #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 20, 2023
c-andy-candies
requested review from
dessalines and
SleeplessOne1917
as code owners
|
Once the back-end gets merged, I'll do a lemmy-js-client release so you can add this. |
|
Okay this should be up now, |
|
this should be blocked until my comments on LemmyNet/lemmy#3226 have been addressed. |
|
I think all comments have been addressed, do I need to do something else here? |
|
I think you need to make woodpecker pass |
SleeplessOne1917
approved these changes
Jun 29, 2023
|
So sorry, I made a mistake, I closed it, should I do a new one? |
|
Github isn't letting me reopen it and this PR shows 0 files changed, so I think you will need to open a new one. |
|
Ok I will do a new one, sorry again |
|
Done #1689 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adapted the code from #1345 to add the sorting options for 3, 6 and 9 months which I think would be very cool to have, as someone pointed out here LemmyNet/lemmy#3217
As the original PR I also am currently doing PRs for backend and translations.
LemmyNet/lemmy#3226
LemmyNet/lemmy-translations#69
This is my first contribution so please forgive me if I did something wrong.