Feature add three six and nine months options backend #3226
Conversation
|
Seems fine, but we shouldnt add any more after this. It will already result in a very long list. |
| -- rename the old enum | ||
| alter type sort_type_enum rename to sort_type_enum__; | ||
| -- create the new enum | ||
| CREATE TYPE sort_type_enum AS ENUM ('Active', 'Hot', 'New', 'Old', 'TopDay', 'TopWeek', 'TopMonth', 'TopYear', 'TopAll', 'MostComments', 'NewComments'); |
There was a problem hiding this comment.
this should include the TopHour, TopSixHour and TopTwelveHour enums
There was a problem hiding this comment.
You're right, I was not sure when I made the PR. Since now it has been merged, should I do another PR correcting it?
There was a problem hiding this comment.
usually there's no take backsies with migrations, but I think in this case it's a down migration and is probably fine just opening a new PR with the hotfix of this file.
There was a problem hiding this comment.
Opened a PR #3370
|
see: https://app.element.io/#/room/#lemmydev:matrix.org/$NZC0fV-P3hxQA4q8RTbtCXBQ8cMOEbX5g4UTRxbDG4U |
I adapted the code from #3161 to add the sorting options for 3, 6 and 9 months which I think would be very cool to have, as someone pointed out here #3217
As the original PR I also am currently doing PRs for frontend and translations.
LemmyNet/lemmy-ui#1420
LemmyNet/lemmy-translations#69
This is my first contribution so please forgive me if I did something wrong.