Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

02 Fx/ 00 TypeScript #78

Closed
wants to merge 6 commits into from
Closed

Conversation

jacobovirtual
Copy link
Collaborator

@jacobovirtual jacobovirtual commented Mar 25, 2017

#60 All is correct, only I change one picture that not correspond to process description.

@nasdan
Copy link
Member

nasdan commented Mar 27, 2017

Hi @jacobovirtual, about the image, it's correct because it's representing that when we use import * as $ from 'jquery' we have intellisense for jquery library

@jacobovirtual
Copy link
Collaborator Author

jacobovirtual commented Mar 27, 2017

I think the highlighted CSS line can cause confusion. That is why I changed the image.
Because at the moment I'm not configuring intellisense for jquery.

@nasdan
Copy link
Member

nasdan commented Mar 27, 2017

Before image, we have configured intellisense for jquery:

  • npm install @types/jquery --save-dev
  • And import * as $ from 'jquery';

@nasdan
Copy link
Member

nasdan commented Mar 29, 2017

There are conflicts with master, could you solve, please?

I think you have to pull the last version of master to your repository, because in this issue #62 I solved Readme links.

@jacobovirtual
Copy link
Collaborator Author

I'm sorry, I'm forgot launch a 'git pull lemoncode master' command over my branch.

@@ -97,6 +97,11 @@ document.write(messageToDisplay);

```

<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove conflicts stuff

@@ -97,6 +97,11 @@ document.write(messageToDisplay);

```

<<<<<<< HEAD
- Here we can see the result of instalation the jquery typings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo installing

@jacobovirtual
Copy link
Collaborator Author

I don't believe, I'm forgot save the file.
-1 to me

@@ -97,6 +97,8 @@ document.write(messageToDisplay);

```

- Here we can see the result of instalation the jquery typings
Copy link
Member

@nasdan nasdan Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is better to say: result by installing.
What do you think?

@nasdan
Copy link
Member

nasdan commented Apr 6, 2017

Hi @jacobovirtual, do you have pending push the changes or something like that?

@nasdan nasdan closed this Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants