Reviewed Readme.md and step by step guide. Issue #67 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated code sample. Added image.
nasdan
reviewed
Apr 6, 2017
02 Fx/03 Angular 2/README.md
Outdated
| "noImplicitAny": false, | ||
| "sourceMap": true, | ||
| - "noLib": false, | ||
| "suppressImplicitAnyIndexErrors": true |
There was a problem hiding this comment.
Add comma to the end of line:
you can add like:
- "suppressImplicitAnyIndexErrors": true
+ "suppressImplicitAnyIndexErrors": true,
+ "lib": ["dom", "es2015"]
nasdan
reviewed
Apr 6, 2017
02 Fx/03 Angular 2/README.md
Outdated
| @@ -191,13 +209,10 @@ module.exports = { | |||
| "declaration": false, | |||
| "noImplicitAny": false, | |||
| "sourceMap": true, | |||
| "noLib": false, | |||
| - "suppressImplicitAnyIndexErrors": true | |||
There was a problem hiding this comment.
I think this line should be looks like:
"suppressImplicitAnyIndexErrors": true,
- "lib": ["dom", "es2015"]
+ "lib": ["dom", "es2015"],
+ "experimentalDecorators":true
nasdan
reviewed
Apr 6, 2017
02 Fx/03 Angular 2/tsconfig.json
Outdated
| "suppressImplicitAnyIndexErrors": true, | ||
| "experimentalDecorators": true, | ||
| "lib": ["dom", "es2015"] , |
|
Great stuff! Only some comments about tsconfig |
nasdan
reviewed
Apr 6, 2017
| - Creating a service. | ||
| - Displaying the component. | ||
| - Creating an external HTML template and consuming it. | ||
| - Install Angular 1.x libraries. |
There was a problem hiding this comment.
If we change Summary steps I think we have to change root Readme
nasdan
reviewed
Apr 6, 2017
| @@ -306,7 +352,7 @@ npm install @types/webpack-env --save-dev | |||
|
|
|||
There was a problem hiding this comment.
In this section, it should looks like:
"lib": ["dom", "es2015"],
- "experimentalDecorators":true
+ "experimentalDecorators":true,
+ "types": [
+ "webpack-env"
+ ]
tsconfig.json fixes.
|
I have included the changes that you have commented. |
|
I think its ready to merge, isn't it? Did you close PR by mistake? |
nasdan
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found different issues during step by step guide execution.