マルチモジュール対応 #56
Merged
マルチモジュール対応 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoAndo
commented
Jan 3, 2023
| @@ -105,7 +105,7 @@ private fun DetailScreenStateless( | |||
| @PreviewDevices | |||
| @Composable | |||
| private fun Prev_DetailScreen() { | |||
| val data = RepositoryDetail( | |||
| val data = com.leoleo.androidgithubsearch.domain.model.RepositoryDetail( | |||
LeoAndo
commented
Jan 3, 2023
| @@ -5,7 +5,7 @@ import com.leoleo.androidgithubsearch.domain.model.RepositoryDetail | |||
| sealed interface UiState { | |||
| object Initial : UiState | |||
| object Loading : UiState | |||
| data class Data(val repositoryDetail: RepositoryDetail) : UiState | |||
| data class Data(val repositoryDetail: com.leoleo.androidgithubsearch.domain.model.RepositoryDetail) : UiState | |||
LeoAndo
commented
Jan 3, 2023
| @@ -62,7 +67,7 @@ fun SearchScreen( | |||
| @Composable | |||
| private fun SearchScreenStateless( | |||
| modifier: Modifier, | |||
| githubRepositories: LazyPagingItems<RepositorySummary>, | |||
| githubRepositories: LazyPagingItems<com.leoleo.androidgithubsearch.domain.model.RepositorySummary>, | |||
LeoAndo
commented
Jan 3, 2023
| @@ -168,7 +173,7 @@ private fun LazyListScope.errorContent( | |||
| @Composable | |||
| private fun Prev_Initial_SearchScreen() { | |||
| val githubRepositories = | |||
| flowOf<PagingData<RepositorySummary>>(PagingData.empty()).collectAsLazyPagingItems() | |||
| flowOf<PagingData<com.leoleo.androidgithubsearch.domain.model.RepositorySummary>>(PagingData.empty()).collectAsLazyPagingItems() | |||
LeoAndo
commented
Jan 3, 2023
| private val query: String, | ||
| private val api: GithubApi, | ||
| private val ktorHandler: KtorHandler, | ||
| ) : PagingSource<Int, RepositorySummary>() { | ||
| ) : PagingSource<Int, com.leoleo.androidgithubsearch.domain.model.RepositorySummary>() { |
LeoAndo
commented
Jan 3, 2023
| private val api: GithubApi, | ||
| private val ktorHandler: KtorHandler, | ||
| ) : GithubRepoRepository { | ||
| ) : com.leoleo.androidgithubsearch.domain.repository.GithubRepoRepository { |
LeoAndo
commented
Jan 3, 2023
| ktorHandler.dataOrThrow { api.fetchRepositoryDetail(ownerName, repositoryName) } | ||
|
|
||
| override fun searchRepositories(query: String): Flow<PagingData<RepositorySummary>> { | ||
| override fun searchRepositories(query: String): Flow<PagingData<com.leoleo.androidgithubsearch.domain.model.RepositorySummary>> { |
LeoAndo
commented
Jan 3, 2023
| @@ -12,4 +14,5 @@ plugins { | |||
| id 'com.android.library' version '7.3.1' apply false | |||
| id 'org.jetbrains.kotlin.android' version '1.7.20' apply false | |||
| id 'org.jetbrains.kotlin.plugin.serialization' version '1.7.20' apply false | |||
| id 'org.jetbrains.kotlin.jvm' version '1.7.20' apply false | |||
There was a problem hiding this comment.
domain module追加時に自動的に追加された。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #55
internalをつけてモジュールスコープにしているdata module作成時のテンプレートはAndroid Libraryを使用
domain module作成時のテンプレートはJava or Kotlin Libraryを使用
設計図