Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to update benchmark collection to observable table format #88

Merged
merged 3 commits into from
Jan 27, 2020
Merged

Add script to update benchmark collection to observable table format #88

merged 3 commits into from
Jan 27, 2020

Conversation

dweindl
Copy link
Collaborator

@dweindl dweindl commented Jan 25, 2020

./to_observable_table.py

@LeonardSchmiester
Copy link
Owner

Looks good. Did you already test it on the existing benchmark models?

@dweindl
Copy link
Collaborator Author

dweindl commented Jan 27, 2020 •
edited
Loading

Looks good. Did you already test it on the existing benchmark models?

Yes, worked for me for all that are expected to work. Some files have still minor issues. Multiple models (Becker) and missing files are not handled.

EDIT: requires PEtab from PEtab-dev/PEtab#244

@LeonardSchmiester LeonardSchmiester merged commit 0020cf7 into hackathon Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonardSchmiester LeonardSchmiester LeonardSchmiester approved these changes

Assignees

@LeonardSchmiester LeonardSchmiester

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweindl @LeonardSchmiester