Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global config #10

Merged
merged 27 commits into from
Apr 16, 2024
Merged

Global config #10

merged 27 commits into from
Apr 16, 2024

Conversation

Leonils
Copy link
Owner

@Leonils Leonils commented Apr 15, 2024

Read global config and load devices from it

@Leonils Leonils self-assigned this Apr 15, 2024
@Leonils Leonils marked this pull request as draft April 15, 2024 16:29
@Leonils
Implement build_from_toml_table for mountedFolder
ebaff65
@Leonils
Raise error if there are 2 devices with same name
b2953cf
@Leonils
Refactor global config loading
e1a0e0e
@Leonils
Implement add device to config
ba64f13
@Leonils
Add write config file method to GlobalConfigProvider
986a5d0
@Leonils
Use automock to mock the global config provider
2346c03
@Leonils
Add a save method on global config
ff6d731
@Leonils
Implement save devices in config
1e4064a
@Leonils
Verify multiple device config saving
9df2437
@Leonils
Implement serialization of mounted folder to toml
8b5a634
@Leonils
Add the global_config_provider to device operations
7ea1596
@Leonils
Implement listing devices from non empty config
369ebfb
@Leonils
Implement adding a device to empty config
2650954
@Leonils
Test when adding a device to config with another device already
c331220
@Leonils
Implement remove device in global config
46bf6b2
@Leonils
Implement operation remove device by name
1827a10
@Leonils
remove _dir at the end of global config provider trait
7856765
@Leonils Leonils changed the title Global config [[WIP]] Global config Apr 16, 2024
@Leonils Leonils marked this pull request as ready for review April 16, 2024 10:48
DarkPitoune
DarkPitoune approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@DarkPitoune DarkPitoune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. I think ^^'

@Leonils Leonils merged commit 7081f81 into main Apr 16, 2024
@Leonils Leonils deleted the feature/global-config branch April 23, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkPitoune DarkPitoune DarkPitoune approved these changes

@GauthierDoppler GauthierDoppler Awaiting requested review from GauthierDoppler

Assignees

@Leonils Leonils

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leonils @DarkPitoune