Better error handling and file_name #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have noticed that the `S3.upload()` method returns success (`percent_uploaded` = 100, `url`, etc.) even when the Amazon S3 does not return HTTP 200 (OK) - for example due to misconfiguration (missing `S3.config.region`, in my case). In addition to this, I believe the error-handling logic in `Meteor.methods._S3upload` is faulty, mainly to the fact, that if you throw `new Meteor.Error` inside the `S3.knox.putStream (ClientRequest)` context, it brings down the whole application (unhandled exception). Throwing error from `_S3upload` context is fine and results in `err` being propagated back to the client via callback.
This was referenced Nov 28, 2014
…live/private/packageForks/S3 with conflicts.
|
committed more than I wanted by mistake :) |
|
Excellent, I've folded these changes into the development branch. Hope to release a couple of changes over the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #49
and fix for #48