Allow app Initialization #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have any questions, concerns, or would like to discuss the implications of the change, please feel free to contact me at luis@sunluxshop.com
|
Thank you very much for that patch, I don't see any reason not to include it in the project 😄 However, could you please add one unit test and update the README? |
|
It's my pleasure. I already started on the README locally. But I won't be able to really do much till after the 15th. If you don't mind a slight wait, I will definitely take care of it before the month |
|
🆙 I can handle that by the end of the week |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for an express app to be passed in as a model for all express routing. Particularly for use with other express wrappers.