Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instant messaging with WebSocket #344

Merged
merged 7 commits into from
May 25, 2024
Merged

Instant messaging with WebSocket #344

merged 7 commits into from
May 25, 2024

Conversation

blu3eee
Copy link
Contributor

@blu3eee blu3eee commented May 24, 2024 •
edited
Loading

[Backend]

  • Apply changes in database models for conversations, messages, and conversation participants
  • API endpoints for /conversations (create conversations, get conversation messages, and get users/accounts' conversations)
  • Added tests for said endpoints

[DevOps]

@blu3eee
#336 use uvicorn instead of daphne for hot-reloading
bd860cc 
use uvicorn instead of daphne to run asgi backend app so it can be hot-reloaded on dev environment
@blu3eee
#149 store conversations and messages
0cf2ad1 
- change in database models for conversations, messages, and conversation participants
- api endpoints for conversation related information
- api endpoint for user's conversation at `/accounts/{accountID}/conversations`
- tests for said endpoints
@blu3eee
#148 add pytest for websocket testing
39402c6
@blu3eee
#148 instant messaging
c5964c2 
- setup websocket for messaging system
- receiving messages from the server to clients in real-time.
shotoh
shotoh reviewed May 25, 2024
View reviewed changes
Copy link
Contributor

@shotoh shotoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

mesh/conversation/views.py Outdated Show resolved Hide resolved
mesh/conversation/views.py Outdated Show resolved Hide resolved
mesh/tests/chat_wsclient_pytests.py Outdated Show resolved Hide resolved
mesh/conversation/views.py Outdated Show resolved Hide resolved
misslame
misslame approved these changes May 25, 2024
View reviewed changes
Copy link
Collaborator

@misslame misslame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you update dependencies? i have never seen this view in github before kinda cool. I will approve for now but shotoh had good questions about the exceptions.

Pipfile Show resolved Hide resolved
Pipfile Show resolved Hide resolved
mesh/conversation/views.py Show resolved Hide resolved
@blu3eee
#344 handle exceptions more consistent
2d7da47
@blu3eee
#344 remove unnecessary json.dumps
91e92b0
@blu3eee
#344 added daphne (again)
5e2eb51 
earlier I removed daphne from dependencies as I thought we don't need it anymore for the ASGI server, but apparently we do need it for the Django channels layer when performing test with `channels.testing`
Reference: django/channels#1942
@blu3eee blu3eee merged commit b658d9c into dev May 25, 2024
@blu3eee blu3eee deleted the leaf/jack/store-conversations branch May 25, 2024 16:37
@blu3eee blu3eee mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misslame misslame misslame approved these changes

@shotoh shotoh shotoh approved these changes

@JRSiwiecki JRSiwiecki Awaiting requested review from JRSiwiecki

@Darren52BT Darren52BT Awaiting requested review from Darren52BT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blu3eee @misslame @shotoh