Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend refactor #348

Merged
merged 9 commits into from
Jun 9, 2024
Merged

Frontend refactor #348

merged 9 commits into from
Jun 9, 2024

Conversation

blu3eee
Copy link
Contributor

@blu3eee blu3eee commented May 24, 2024

see #346

@blu3eee
Copy link
Contributor Author

blu3eee commented May 24, 2024

Disclaimer: this PR is a proposal of change to the current frontend files and folders structure because it's looking confusing to me whenever I want to contribute to frontend code. I can't find a code of conduct/contributing guide for frontend anywhere for the project so I'm proposing a change for it, and if it is approved, I can make a contributing guide for frontend for people to follow whenever they want to contribute to frontend (/meshapp).

Darren52BT
Darren52BT approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@Darren52BT Darren52BT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great in my view, the guide looks good too. I think maybe you could add joining the discord for further details on sprint standards like when you're talking about creating a branch and naming it properly, but since that's already in the main README that may be pretty redundant. nice work!

@blu3eee
Copy link
Contributor Author

blu3eee commented Jun 8, 2024 •
edited
Loading

note: I cherry-picked the changes from #351 so this should be merge after said PR
#351 is merged so this is merge-able

blu3eee and others added 3 commits June 8, 2024 10:32
@blu3eee
Revert "added post, patch, and delete calls"
5245be6 
This reverts commit c76ffcd.
@shotoh @blu3eee
#3: added axios calls to change or delete profile picture
39cd54a 
* added post, patch, and delete calls

* changed file checking to extensions
@blu3eee
Merge branch 'dev' of https://github.com/LetsMesh/Site into leaf/jack…
6b64589 
…/frontend-refactoring
@blu3eee blu3eee requested a review from JRSiwiecki June 8, 2024 15:42
JRSiwiecki
JRSiwiecki approved these changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@JRSiwiecki JRSiwiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 great refactor, really not much to say but i do agree with darren that there should be a link to the discord in the readme

@blu3eee blu3eee merged commit 48199ec into dev Jun 9, 2024
@blu3eee blu3eee deleted the leaf/jack/frontend-refactoring branch June 9, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRSiwiecki JRSiwiecki JRSiwiecki approved these changes

@Darren52BT Darren52BT Darren52BT approved these changes

@misslame misslame Awaiting requested review from misslame

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blu3eee @JRSiwiecki @Darren52BT @shotoh