Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaf/A6.1 Implemented Inputting and Changing Occupation #360

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Darren52BT
Copy link
Contributor

addresses #65

I have implemented being able to input and change occupation, which includes deleting and editing. I did this through just mostly copying how ProfileGroupAccordion was utilized for Education. I think this issue is supposed to also include the user's current occupation, but there's currently already some textfields that I think Patrick created before that suit this purpose already, so what this PR is doing is just implementing Experience history.

Changes

  • I added a new type for Experience
  • reusing ProfileGroupAccordion and passing into it a state variable containing Experience data and editing, deleting, and adding handlers into it.

I still need to do theming on this which I need the PR for the profile page theming bug to be merged in for.

What you should see

image
image
image

@Darren52BT Darren52BT linked an issue Jun 24, 2024 that may be closed by this pull request
Copy link
Contributor

@blu3eee blu3eee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Darren52BT Darren52BT merged commit 97a7fff into dev Jul 2, 2024
2 checks passed
@Darren52BT Darren52BT deleted the leaf/A6.1-Input/Change_Occupation branch July 2, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A6.1 Input/Change Occupation
3 participants