Skip to content

Commit eb08363

Browse files
committed
Make internal iterator decoding options enumerable
Otherwise they're lost when an implementation clones options.
1 parent 90b8816 commit eb08363

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

abstract-level.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -654,8 +654,8 @@ class AbstractLevel extends EventEmitter {
654654
options.values = options.values !== false
655655

656656
// We need the original encoding options in AbstractIterator in order to decode data
657-
Object.defineProperty(options, AbstractIterator.keyEncoding, { value: keyEncoding })
658-
Object.defineProperty(options, AbstractIterator.valueEncoding, { value: valueEncoding })
657+
options[AbstractIterator.keyEncoding] = keyEncoding
658+
options[AbstractIterator.valueEncoding] = valueEncoding
659659

660660
// Forward encoding options to private API
661661
options.keyEncoding = keyEncoding.format
@@ -684,8 +684,8 @@ class AbstractLevel extends EventEmitter {
684684
options = rangeOptions(options, keyEncoding)
685685

686686
// We need the original encoding options in AbstractKeyIterator in order to decode data
687-
Object.defineProperty(options, AbstractIterator.keyEncoding, { value: keyEncoding })
688-
Object.defineProperty(options, AbstractIterator.valueEncoding, { value: valueEncoding })
687+
options[AbstractIterator.keyEncoding] = keyEncoding
688+
options[AbstractIterator.valueEncoding] = valueEncoding
689689

690690
// Forward encoding options to private API
691691
options.keyEncoding = keyEncoding.format
@@ -713,8 +713,8 @@ class AbstractLevel extends EventEmitter {
713713
options = rangeOptions(options, keyEncoding)
714714

715715
// We need the original encoding options in AbstractValueIterator in order to decode data
716-
Object.defineProperty(options, AbstractIterator.keyEncoding, { value: keyEncoding })
717-
Object.defineProperty(options, AbstractIterator.valueEncoding, { value: valueEncoding })
716+
options[AbstractIterator.keyEncoding] = keyEncoding
717+
options[AbstractIterator.valueEncoding] = valueEncoding
718718

719719
// Forward encoding options to private API
720720
options.keyEncoding = keyEncoding.format

0 commit comments

Comments
 (0)