Breaking: rename highWaterMark to highWaterMarkBytes
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remove a conflict with streams. Also adds documentation. Ref Level/leveldown#468 Ref Level/community#70
vweevers
force-pushed
the
document-hwm
branch
from
2d49754
to
52dc30c
Compare
Fixed in 1c22bf5, rebased. |
This was referenced Feb 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove a conflict with streams (that also exists in
levelup). Also adds documentation, for which review is welcome becausehighWaterMark(Bytes)has been a hidden option for a long time but can increase throughput significantly.Ignore failing tests, that's unrelated, something with the GitHub runner's Visual Studio and
node-gyp. Will handle that separately.Ref Level/leveldown#468
Ref Level/community#70