make member options optional

Author: juliangruber

README.md

@@ -19,31 +19,31 @@
 var codec = new Codec(db.options);
 ```
 
-### #encodeKey(key, opts)
+### #encodeKey(key[, opts])
 
   Encode `key` with given `opts`.
 
-### #encodeValue(value, opts)
+### #encodeValue(value[, opts])
 
   Encode `value` with given `opts`.
 
-### #encodeBatch(batch, opts)
+### #encodeBatch(batch[, opts])
 
   Encode `batch` ops with given `opts`.
 
-### #decodeKey(key, opts)
+### #decodeKey(key[, opts])
 
   Decode `key` with given `opts`.
 
-### #decodeValue(value, opts)
+### #decodeValue(value[, opts])
 
   Decode `value` with given `opts`.
 
-### #keyAsBuffer(opts)
+### #keyAsBuffer([opts])
 
   Check whether `opts` and the global `opts` call for a binary key encoding.
 
-### #valueAsBuffer(opts)
+### #valueAsBuffer([opts])
 
   Check whether `opts` and the global `opts` call for a binary value encoding.
 

index.js

@@ -15,13 +15,13 @@ Codec.prototype._encoding = function(encoding){
 
 Codec.prototype._keyEncoding = function(opts, batchOpts){
   return this._encoding(batchOpts && batchOpts.keyEncoding
-    || opts.keyEncoding
+    || opts && opts.keyEncoding
     || this.opts.keyEncoding);
 };
 
 Codec.prototype._valueEncoding = function(opts, batchOpts){
   return this._encoding(batchOpts && batchOpts.valueEncoding
-    || opts.valueEncoding
+    || opts && opts.valueEncoding
     || this.opts.valueEncoding);
 };
 

test/as-buffer.js

@@ -4,13 +4,15 @@ var Codec = require('..');
 test('key as buffer', function(t){
   var codec = new Codec({ keyEncoding: 'hex' });
   t.ok(codec.keyAsBuffer({}));
+  t.ok(codec.keyAsBuffer());
   t.notOk(codec.keyAsBuffer({ keyEncoding: 'utf8' }));
   t.end();
 });
 
 test('value as buffer', function(t){
   var codec = new Codec({ valueEncoding: 'hex' });
   t.ok(codec.valueAsBuffer({}));
+  t.ok(codec.valueAsBuffer());
   t.notOk(codec.valueAsBuffer({ valueEncoding: 'utf8' }));
   t.end();
 });

test/batch.js

@@ -18,6 +18,12 @@ test('batch', function(t){
     { type: 'put', key: 'json', value: '{}' }
   ]);
 
+  encoded = codec.encodeBatch(ops);
+  t.deepEqual(encoded, [
+    { type: 'put', key: 'string', value: 'string' },
+    { type: 'put', key: 'json', value: {} }
+  ]);
+
   t.end();
 });
 

test/kv.js

@@ -7,6 +7,9 @@ test('encode key', function(t){
   var buf = codec.encodeKey('686579', {});
   t.equal(buf.toString(), 'hey');
 
+  buf = codec.encodeKey('686579');
+  t.equal(buf.toString(), 'hey');
+
   buf = codec.encodeKey('686579', {
     keyEncoding: 'binary'
   });
@@ -21,6 +24,9 @@ test('encode value', function(t){
   var buf = codec.encodeValue('686579', {});
   t.equal(buf.toString(), 'hey');
 
+  buf = codec.encodeValue('686579');
+  t.equal(buf.toString(), 'hey');
+
   buf = codec.encodeValue('686579', {
     valueEncoding: 'binary'
   });
@@ -35,6 +41,9 @@ test('decode key', function(t){
   var buf = codec.decodeKey(new Buffer('hey'), {});
   t.equal(buf, '686579');
 
+  buf = codec.decodeKey(new Buffer('hey'));
+  t.equal(buf, '686579');
+
   buf = codec.decodeKey(new Buffer('hey'), {
     keyEncoding: 'binary'
   });
@@ -49,6 +58,9 @@ test('decode value', function(t){
   var buf = codec.decodeValue(new Buffer('hey'), {});
   t.equal(buf, '686579');
 
+  buf = codec.decodeValue(new Buffer('hey'));
+  t.equal(buf, '686579');
+
   buf = codec.decodeValue(new Buffer('hey'), {
     valueEncoding: 'binary'
   });